Fiscal Year Multiselect #3151

elipe17 · 2024-08-19T19:54:45Z

Summary of Changes

To support multi select, introduced two new multi select filters. One for the year and one for the quarter since it was impossible to keep it at a single filter with our current multi select filter capabilities.
Updated the 508 repo with this PR to reflect the changes here and impending re-architecting in Spike - Investigate Custom Filter Integration #3110
Pull request closes Admin Exp: Django Implement Multi-Select Fiscal Period Dropdown For Data Export #3102

How to Test

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up --build

Open http://localhost:3000/ and sign in.
Submit some data
Visit the search indexes page(s) of your choice and begin filtering. Note how each multiselect filter has it's own filter button again. This was a requirement to have more than one multiselect on a page.
Ensure the filtered data matches your selections

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Search Indexes pages have multiselect fiscal period filter
Testing Checklist has been run and all tests pass
README is updated, if necessary

Deliverable 2: Tested Code

Are all areas of code introduced in this PR meaningfully tested?
- If this PR introduces backend code changes, are they meaningfully tested?
- If this PR introduces frontend code changes, are they meaningfully tested?
Are code coverage minimums met?
- Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
- Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

Are backend code style checks passing on CircleCI?
Are frontend code style checks passing on CircleCI?
Are code maintainability principles being followed?

Deliverable 4: Accessible

Does this PR complete the epic?
Are links included to any other gov-approved PRs associated with epic?
Does PR include documentation for Raft's a11y review?
Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

Does this PR provide background for why coding decisions were made?
If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
If this PR introduces dependencies, are their licenses documented?
Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

Does the OWASP Scan pass on CircleCI?
Do manual code review and manual testing detect any new security issues?
If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

the purpose of the research
methods used to conduct the research
who participated in the research
what was tested and how
impact of research on TDP
(if applicable) final design mockups produced for TDP development

…same page - Updated search_indexes to allow mutliselect for fiscal period

codecov · 2024-08-19T20:03:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (61df98f) to head (0ffc545).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3151      +/-   ##
===========================================
+ Coverage    91.27%   91.61%   +0.33%     
===========================================
  Files          291      291              
  Lines         8072     8075       +3     
  Branches       757      757              
===========================================
+ Hits          7368     7398      +30     
+ Misses         596      594       -2     
+ Partials       108       83      -25

Flag	Coverage Δ
dev-backend	`91.09% <100.00%> (+<0.01%)`	⬆️
dev-frontend	`95.31% <ø> (+2.69%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...drs-backend/tdpservice/search_indexes/admin/ssp.py	`100.00% <100.00%> (ø)`
...rs-backend/tdpservice/search_indexes/admin/tanf.py	`100.00% <100.00%> (ø)`
...-backend/tdpservice/search_indexes/admin/tribal.py	`100.00% <100.00%> (ø)`

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8868eea...0ffc545. Read the comment docs.

tdrs-backend/tdpservice/search_indexes/templates/multiselectdropdownfilter.html

…NF-app into 3102-fy-multiselect

.circleci/build-and-test/workflows.yml

tdrs-backend/Dockerfile

andrew-jameson

Outside of the circleci-workflow commenting, good to go!

…3102-fy-multiselect

ADPennington · 2024-09-09T15:46:55Z

@elipe17 i deployed this to qasp environment and am observing unexpected results when trying to apply any filter. I did clear the browser cache. see below:

elipe17 · 2024-09-09T15:55:06Z

@ADPennington you might have to show me/tell me exactly what your are doing to generate that. I filtered based on your screen shot and everything seems to be working as expected (see below). Let me know how you'd like to proceed.
Screenshot 2024-09-09 at 11 52 55 AM

ADPennington

LGTM @elipe17 🚀

@lfrohlich @ttran-hub @klinkoberstar -- this PR enables the ability to export multiple fiscal periods of records to CSV, but it changes the steps for doing so. Please note:

⚠️ exporting more than 100K records at a time is still not feasible from DAC, so selecting multiple fiscal periods of records to export will reinforce this limitation. We have a few other tickets that explore solutions to the exporting issue (e.g. [bug] OFA unable to export data to csv by record type and fiscal period #3137, Spike - Streamlined access to recent data #3176)
In order export data (from DAC) by fiscal period now, the following steps are required:
- Select the fiscal year(s)
- Click filter by year
- Select the fiscal quarter(s)
- Click filter by quarter
- If needed, make any additional filter selections before clicking Apply Filters.
- ℹ️ A video of these steps are saved in our Teams Channel here 🔐 .

elipe17 added 2 commits August 19, 2024 15:32

- Update multi select template to allow multiple fitlers to exist on …

18b58d9

…same page - Updated search_indexes to allow mutliselect for fiscal period

- Update 508

752c40f

elipe17 added backend dev raft review This issue is ready for raft review DAC Django Admin Console labels Aug 19, 2024

elipe17 requested review from andrew-jameson, raftmsohani and jtimpe August 19, 2024 19:54

elipe17 self-assigned this Aug 19, 2024

elipe17 requested review from reitermb and victoriaatraft August 19, 2024 19:55

raftmsohani reviewed Aug 26, 2024

View reviewed changes

tdrs-backend/tdpservice/search_indexes/templates/multiselectdropdownfilter.html Show resolved Hide resolved

- remove whitespace

1ac2269

elipe17 added the Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI label Aug 26, 2024

victoriaatraft added Deploy with CircleCI-a11y Deploy to https://tdp-frontend-a11y.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Aug 26, 2024

reitermb added Deploy with CircleCI-a11y Deploy to https://tdp-frontend-a11y.app.cloud.gov through CircleCI and removed Deploy with CircleCI-a11y Deploy to https://tdp-frontend-a11y.app.cloud.gov through CircleCI labels Aug 26, 2024

jtimpe approved these changes Aug 27, 2024

View reviewed changes

- regenerate lock as test

3bb86e2

elipe17 added the Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI label Aug 27, 2024

elipe17 and others added 3 commits August 28, 2024 12:38

Merge branch 'develop' into 3102-fy-multiselect

efccead

- testing

68719d4

Merge branch '3102-fy-multiselect' of https://github.com/raft-tech/TA…

0da2af1

…NF-app into 3102-fy-multiselect

elipe17 added Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Aug 28, 2024

victoriaatraft approved these changes Aug 29, 2024

View reviewed changes

andrew-jameson added Deploy with CircleCI-a11y Deploy to https://tdp-frontend-a11y.app.cloud.gov through CircleCI and removed Deploy with CircleCI-raft Deploy to https://tdp-frontend-raft.app.cloud.gov through CircleCI labels Aug 30, 2024

andrew-jameson reviewed Aug 30, 2024

View reviewed changes

.circleci/build-and-test/workflows.yml Outdated Show resolved Hide resolved

andrew-jameson reviewed Aug 30, 2024

View reviewed changes

tdrs-backend/Dockerfile Outdated Show resolved Hide resolved

andrew-jameson approved these changes Aug 30, 2024

View reviewed changes

elipe17 and others added 4 commits August 30, 2024 10:19

- revert changes

0b656e1

Merge branch 'develop' into 3102-fy-multiselect

e36c8b9

Merge branch 'develop' of https://github.com/raft-tech/TANF-app into …

6371649

…3102-fy-multiselect

- Updating lock file and pipfile

d829e00

elipe17 added QASP Review and removed raft review This issue is ready for raft review labels Sep 6, 2024

elipe17 requested a review from ADPennington September 6, 2024 14:48

ADPennington removed the Deploy with CircleCI-a11y Deploy to https://tdp-frontend-a11y.app.cloud.gov through CircleCI label Sep 9, 2024

Merge branch 'develop' into 3102-fy-multiselect

8e8ef44

ADPennington added the Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI label Sep 9, 2024

ADPennington approved these changes Sep 9, 2024

View reviewed changes

ADPennington added Ready to Merge and removed QASP Review Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI labels Sep 9, 2024

Merge branch 'develop' into 3102-fy-multiselect

0ffc545

andrew-jameson merged commit 7f1e28d into develop Sep 10, 2024
14 checks passed

andrew-jameson deleted the 3102-fy-multiselect branch September 10, 2024 13:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fiscal Year Multiselect #3151

Fiscal Year Multiselect #3151

elipe17 commented Aug 19, 2024 •

edited by ADPennington

Loading

codecov bot commented Aug 19, 2024 •

edited

Loading

andrew-jameson left a comment

ADPennington commented Sep 9, 2024

elipe17 commented Sep 9, 2024 •

edited

Loading

ADPennington left a comment

Fiscal Year Multiselect #3151

Fiscal Year Multiselect #3151

Conversation

elipe17 commented Aug 19, 2024 • edited by ADPennington Loading

Summary of Changes

How to Test

Deliverables

codecov bot commented Aug 19, 2024 • edited Loading

Codecov Report

andrew-jameson left a comment

Choose a reason for hiding this comment

ADPennington commented Sep 9, 2024

elipe17 commented Sep 9, 2024 • edited Loading

ADPennington left a comment

Choose a reason for hiding this comment

elipe17 commented Aug 19, 2024 •

edited by ADPennington

Loading

codecov bot commented Aug 19, 2024 •

edited

Loading

elipe17 commented Sep 9, 2024 •

edited

Loading